Skip to content

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Jan 28, 2026

Additional Information

v23.0.2 (cdc5a63) This PR (WIP code)
Build doesn't have have decoration icons
Build cannot filter by node type

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

kwvg added 27 commits January 29, 2026 01:07
Also `s/coinJoinEnabledChanged/showCoinJoinChanged/g` to establish a
naming convention that will be used soon.
This should fix the misalignment of the `subFeeFromAmount` `QCheckBox`
compared to the rest of the `QCheckBox`es

Review with `git log -p -n1 --ignore-space-change --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Inheriting the whole structure is overkill just to use `tr` and `hash()`
is used in hot loops so we should cache the value in the ctor.

Also remove dead variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant